Quoting Subrata Modak ([EMAIL PROTECTED]): > > > Quoting Subrata Modak ([EMAIL PROTECTED]): > > > > > > Here is a patch to add some file capability tests to ltp. > > > > > > > > > > > > > > > > Thanks. I am running this and will get back to you soon. > > > > > > > > > > > > > I am not able to execute this through: > > > > > > > > ./runltp -f filecaps, > > > > On further investigation i found that "filecapstest.sh" is not present > > > > inside testcases/bin. Is some twiking needs to be done @: > > > > > > > > ltp-full-20071231/testcases/kernel/security/filecaps/Makefile > > > > > > Ah, yes, until yesterday I didn't filecaps to be compiled by default > > > since it didn't have a check for existance of libcap. So I had to > > > add filecaps to subdirs in > > > ltp-full-20071231/testcases/kernel/security/Makefile. > > > > > > A new diff is attached. It also has a two-line update for inh_capped.c, > > > which needed spaces added between two multi-line strings, which Andrew > > > pointed out. > > > > > > > Thanks for this. I would check it out again. > > I hit the issue again. Here is the output which is get after i have > built, installed and ran ltp: > > <<<test_start>>> > tag=Filecaps stime=1201014329 > cmdline="filecapstest.sh" > contacts="" > analysis=exit > initiation_status="pan(3179): execvp of 'filecapstest.sh' (tag Filecaps) > failed. errno:2 No such file or directory" > <<<test_output>>> > <<<execution_status>>> > duration=0 termination_type=exited termination_id=2 corefile=no > cutime=0 cstime=0 > <<<test_end>>> > > I gave execute permissions to all the scripts under > testcases/kernel/security/filecaps/. Installed once again but still was > not able to trace out 'filecapstest.sh' under testcases/bin. > > The issue to me seems to be here in the code: > > diff -Nrup ltp-full-20071231/testcases/kernel/security/filecaps/Makefile > ltp-full-20071231-filecaps/testcases/kernel/security/filecaps/Makefile > --- > ltp-full-20071231/testcases/kernel/security/filecaps/Makefile > 1969-12-31 19:00:00.000000000 -0500 > +++ > ltp-full-20071231-filecaps/testcases/kernel/security/filecaps/Makefile > 2008-01-21 12:27:36.000000000 -0500 > @@ -0,0 +1,22 @@ > +ifeq ($(shell sh checkforlibcap.sh),yes) > +CC=gcc > + > +CFLAGS += -I../../../../include -Wall > +LDLIBS += -L../../../../lib -lltp -lcap > + > > Where it will build and install only when ... > > $(shell sh checkforlibcap.sh) > > evaluates to yes. And this is not evaluating to yes although > checkforlibcap.sh is available there.
Ok so you don't have libcap, and can't compile or run the testcases. So it is doing the right thing. Should libcap not being available be handled differently? You can see in checkforlibcap.sh where I uncommented some echos to show where to get libcap. I suppose we can put those in the Makefile somehow when checkforlibcap.sh returns 'no', but I'm not sure of the best way to do that. thanks, -serge - To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
