On Wed, Feb 20, 2008 at 02:38:16PM +0900, Kohei KaiGai wrote: > Greg KH wrote: >> On Wed, Feb 20, 2008 at 01:38:59PM +0900, Kohei KaiGai wrote: >>>>> If we can have a private member in kobj_attribute, we can found the >>> content >>>>> to be returned in a single step. >>>> Ok, again, just send me a patch that adds this functionality and we will >>>> be very glad to consider it. >>> [1/2] Add a private data field within kobj_attribute structure. >>> >>> This patch add a private data field, declared as void *, within >>> kobj_attribute >>> structure. Anyone wants to use sysfs can store their private data to >>> refer at >>> _show() and _store() method. >>> It enables to share a single method function with several similar >>> entries, >>> like ones to export the list of capabilities the running kernel >>> supported. >> But your patch 2/2 doesn't use this interface, why not? > > Really? > The following two _show() methods shared by every capabilities refer > the private member of kobj_attribute. > > | +static ssize_t capability_name_show(struct kobject *kobj, > | + struct kobj_attribute *attr, > | + char *buffer) > | +{ > | + /* It returns numerical representation of capability. */ > | + return scnprintf(buffer, PAGE_SIZE, "%d\n", (int) attr->data); > | +} > | + > | +static ssize_t capability_code_show(struct kobject *kobj, > | + struct kobj_attribute *attr, > | + char *buffer) > | +{ > | + /* It returns symbolic representation of capability. */ > | + return scnprintf(buffer, PAGE_SIZE, "%s\n", (char *) attr->data); > | +}
Ah, sorry, missed that. I also missed where this was set up as well :( thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html