Re: a better reschedule_idle() and goodness()

[Linus Torvalds]

On Mon, 21 Dec 1998, Rik van Riel wrote:
> 
> Don't try it yet -- it seems like I ran into a bug where
> smp_send_reschedule() only sends reschedule signals to
> CPU 0...
> 
> The bug is in arch/i386/kernel/smp.c::smp_message_pass(),
> on line 1324:
> 
>         {
>                 dest=0;
>                 target_map=(1<<target);
>                 cpu_callin_map[0]=0;
>         }

Good spotting.

> I guess 'dest = SET_APIC_DEST_FIELD(target)' would give
> better results, but since I don't know the SMP code yet
> I haven't tried it myself...

No, the "dest" field has this strange format where you can specify both
the destination shorthand and the real destination at once. I'll fix the
problem and write some comments to that effect too.

                Linus

-
Linux SMP list: FIRST see FAQ at http://www.irisa.fr/prive/mentre/smp-faq/
To Unsubscribe: send "unsubscribe linux-smp" to [EMAIL PROTECTED]