Le 28/01/2020 à 06:48, Qian Cai a écrit :
On Jan 27, 2020, at 11:58 PM, Anshuman Khandual <anshuman.khand...@arm.com>
wrote:
As I had mentioned before, the test attempts to formalize page table helper
semantics
as expected from generic MM code paths and intend to catch deviations when
enabled on
a given platform. How else should we test semantics errors otherwise ? There
are past
examples of usefulness for this procedure on arm64 and on s390. I am wondering
how
else to prove the usefulness of a debug feature if these references are not
enough.
Not saying it will not be useful. As you mentioned it actually found a bug or
two in the past. The problem is that there is always a cost to maintain
something like this, and nobody knew how things could be broken even for the
isolated code you mentioned in the future given how complicated the kernel code
base is. I am not so positive that many developers would enable this debug
feature and use it on a regular basis from the information you gave so far.
On the other hand, it might just be good at maintaining this thing out of tree
by yourself anyway, because if there isn’t going to be used by many developers,
few people is going to contribute to this and even noticed when it is broken.
What’s the point of getting this merged apart from being getting some
meaningless credits?
It is 'default y' so there is no much risk that it is forgotten, at
least all test suites run with 'allyes_defconfig' will trigger the test,
so I think it is really a good feature.
Christophe
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
