On 2/19/20 12:30 AM, Andreas Schwab wrote: > On Feb 19 2020, Vineet Gupta wrote: > >> On 2/18/20 5:03 PM, Alistair Francis wrote: >>>>> +#define STAT_IS_KERNEL_STAT 1 >>>> Isn't this irrelevant: seems to be only used for legacy >>>> __NR_stat/__NR_stat64 >>>> syscalls based__xstat()/__xstat64(). >>> Is it? It seems to be used in a few places, including: >>> >>> sysdeps/unix/sysv/linux/fxstatat.c >>> sysdeps/unix/sysv/linux/xstatconv.c >> AFAIK that is not part of the asm-generic syscall ABI which ARC, RISCV et al >> use ! > > The latter is still included by everyone, though.
Correct, although it only builds a "dummy" struct for #ifdef STAT_IS_KERNEL_STAT i.e. for either values of this define - we might as well move that dummy out and make the rest of code ifndef. Rest of code in that function __xstat_conv is not meant for asm-generic syscall ABI anyways. Thx, -Vineet _______________________________________________ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
