Hi Vadim , Shahab Thanks for the feedback
> > The original code is obviously optimized out, but the intention, I > > believe, was to check if the jump is conditional or not. > > So the proper fix should change the code to check cond: > > > > - if (ARC_CC_AL) > > + if (cond == ARC_CC_AL) Okay > That is absolutely correct. If a new patch is not submitted soon > I'll try to fix it myself. if you are okay with that then I can proceed by submitting version 2 of the patch with the proposed changes included Best Regards, Hardev ________________________________________ From: Shahab Vahedi <[email protected]> Sent: Wednesday, November 13, 2024 7:41 AM To: Vadim Fedorenko <[email protected]>; Hardevsinh Palaniya <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Cc: Daniel Borkmann <[email protected]>; Martin KaFai Lau <[email protected]>; Eduard Zingerman <[email protected]>; Song Liu <[email protected]>; Yonghong Song <[email protected]>; John Fastabend <[email protected]>; KP Singh <[email protected]>; Stanislav Fomichev <[email protected]>; Hao Luo <[email protected]>; Jiri Olsa <[email protected]>; Vineet Gupta <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Subject: Re: [PATCH] ARC: bpf_jit_arcv2: Remove redundant condition check CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Vadim Fedorenko wrote: > The original code is obviously optimized out, but the intention, I > believe, was to check if the jump is conditional or not. > So the proper fix should change the code to check cond: > > - if (ARC_CC_AL) > + if (cond == ARC_CC_AL) That is absolutely correct. If a new patch is not submitted soon I'll try to fix it myself. Cheers, Shahab _______________________________________________ linux-snps-arc mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-snps-arc
