On Sat, Jan 15, 2005 at 10:19:03AM -0800, Linus Torvalds wrote:
> This should fix it.. (Only duplicate the initializer if the symbol itself
> has been duplicated)
Pulled sparse from bkbits - I can confirm it is fixed both for
my test-case and for the kernel.
With defconfig kernel/ is now sparse clean.
But the patch below did not make sense to me - seems like a very old
one?
Anyway - the patch at bkbits looked nice.
Sam
> ----
> ===== linearize.c 1.49 vs edited =====
> --- 1.49/linearize.c 2004-08-20 11:43:58 -07:00
> +++ edited/linearize.c 2004-09-04 17:52:44 -07:00
> @@ -1114,7 +1114,7 @@
> }
> }
>
> -void pack_basic_blocks(struct basic_block_list **bblist)
> +void pack_basic_blocks(struct basic_block *entry, struct basic_block_list
> **bblist)
> {
> struct basic_block *bb;
> struct list_iterator iterator;
> @@ -1129,7 +1129,8 @@
>
> if (!is_branch_goto(jmp=last_instruction(bb->insns)))
> continue;
> -
> + if (bb == entry)
> + continue;
> target = jmp->bb_true ? jmp->bb_true : jmp->bb_false;
> if (target == bb)
> continue;
> @@ -1189,7 +1190,7 @@
> insn->src = result;
> add_one_insn(ep, pos, insn);
> }
> - pack_basic_blocks(&ep->bbs);
> + pack_basic_blocks(bb, &ep->bbs);
> ret_ep = ep;
> }
> }
-
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
