On Sun, Nov 24, 2013 at 02:12:55PM +0000, Mark Brown wrote:
> On Sun, Nov 24, 2013 at 09:37:01AM -0300, Ezequiel Garcia wrote:
> > The GPIO chip in use could be of any kind, and therefore might sleep
> > when accesing the GPIO lines. Take account of this by using cansleep
> > instead, which is the most generic case.
> 
> Applied, thanks.

Mark:

I'm just wondering -as I don't have much experience with gpiolib-
is this replacement the Right Thing To Do?

It seemed to me that the xxx_cansleep variant just adds a check
and a might_sleep, so this change won't hurt the general case.

Is this correct?
-- 
Ezequiel GarcĂ­a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to