Dave, If you can put the patch up somewhere I'd like to both test it and inspect it as you suggest.
I'd particularly like to see how Matt did kmem_cache of mblks. Particularly because if the LiS mechanism to put mblks on a free list is still used it defeats all of the caching benefit of kmem_caches (because the cache fragments anyway). Also, mblks and dblks are allocated together in the method currently used by LiS, it also largely defeats using kmem caches, (because locality of reference is not assured and independent cache slots would exhibit superior performance). I would also like to see the improvements for caching and indexing of timer ids included to avoid expensive searches of timer lists. This patch was contributed earlier. Also, I am confused with your comments regarding Linux kernel-isms. Does LiS run on anything other than Linux? --brian On Mon, 04 Aug 2003, Dave Grothe wrote: > Matt: > > I would be happy to incorporate them. I do have one proviso: Please > ensure that any Linux kernel-isms are confined to > linux-mdep.[ch]. Kernel-isms in other files should be guarded by #ifdef > LINUX, but these tend to disturb the readability of the code, so I prefer > keeping the changes in linux-mdep.[ch]. > > Perhaps a few others would like to test the patches before we incorporate > them into the released version of LiS. > > Thanks for the effort. It sounds like you are taking a good approach. > > -- Dave > > At 02:13 PM 8/4/2003 Monday, Matthew Gierlach wrote: > >Hello Dave: > > > > I have concluded my 1st phase efforts to construct a performance > > enhanced LiS based on off the shelf LiS. > > > > I'll provide the code to the LiS project for the benefit of > > all LiS users. Will you accept the submission and include it > > in the going forward releases? > > > > I have source code for both LiS-2.16.11 and LiS-2.16.12. The > > performance gain is nearly 100% compared to the off the shelf > > LiS distribution. The changes include: > > > > 1) LiS can now be compiled for development or production > > use. The Configure script prompts the user for the > > attribute (development or production) of LiS they > > would like to build. A production built LiS achieves a > > large portion of the 100% performance improvement. > > > > When compiled with the production attribute, LiS code > > path tracing and lock & semaphore use tracing is > > disabled. > > > > Also, with the production attribute, LiS no longer > > obtains __FILE__ and __LINE__ function parameters > > from the LiS user and consequently, no longer carries > > __FILE__ and __LINE__ function parameters through > > to all the internal LiS functions. This reduces LiS > > execution time by eliminating the need for two 32-bit > > stack values for nearly every LiS function call. > > > > 2) LiS can now be compiled to use Linux kmem_cache for > > LiS queue and mblk structures. The Configure script > > prompts the user for this choice. > > > > This is an enhancement that uses Linux kmem_cache > > storage for LiS queue and mblk structures instead > > of conventional kernel memory. > > > > The enhancements have been tested with several Adax drivers > > running for many consecutive days over the past month. > > > > I look forward to your response. > > > > Matt Gierlach - Adax, Inc. > > > _______________________________________________ > Linux-streams mailing list > [EMAIL PROTECTED] > http://gsyc.escet.urjc.es/mailman/listinfo/linux-streams -- Brian F. G. Bidulock � The reasonable man adapts himself to the � [EMAIL PROTECTED] � world; the unreasonable one persists in � http://www.openss7.org/ � trying to adapt the world to himself. � � Therefore all progress depends on the � � unreasonable man. -- George Bernard Shaw � _______________________________________________ Linux-streams mailing list [EMAIL PROTECTED] http://gsyc.escet.urjc.es/mailman/listinfo/linux-streams
