To clarify my second patch: > > > > The next patch, patch2.LiS is a nice to have. LiS failed to load and crashed in > > lis_printk so I first created this patch for a better compile time check of the > > format string and the arguments with the printf like family of functions. > > > > It was not the reason for the crash mentioned above, but nevertheless it shows us > > a lot of compiler warnings we can fix to improve the code, which I did with the > > next patches. > > > Sounds like something else I did a patch for (which I think I also > submitted to Dave for post-K). There was a problem with the order > of includes that resulted in an instance of printk not having the > "mangled modversions suffix." It would show up when compiling > as an implicit declaration of printk, since the kernel's printk > has the mangled suffix. If actually used, I can see how it would > cause a panic. But the patch I submitted should resolve all of > this. >
The patch I submitted adds the format attribute to the functions lis_printk, lis_sprintf and lis_vsprintf. Just have a look at this attribute at http://gcc.gnu.org/onlinedocs/gcc-3.4.0/gcc/Function-Attributes.html#Function%20Attributes Here is the patch again as a spam free inline copy to show what it does: ------------------------------------------------------ --- old/include/sys/osif.h 2004-05-07 17:01:15.000000000 +0200 +++ new/include/sys/osif.h 2004-05-27 02:43:42.000000000 +0200 @@ -658,9 +658,9 @@ /* * Printing routines. */ -int lis_printk(const char *fmt, ...) ; -int lis_sprintf(char *bfr, const char *fmt, ...) ; -int lis_vsprintf(char *bfr, const char *fmt, va_list args) ; +int lis_printk(const char *fmt, ...) __attribute__ ((format (printf, 1, 2))); +int lis_sprintf(char *bfr, const char *fmt, ...) __attribute__ ((format (printf, 2, 3))); +int lis_vsprintf(char *bfr, const char *fmt, va_list args) __attribute__ ((format (printf, 2, 0))); /* * Timer routines. ------------------------------------------------------ Is it possible for you to send me your post-K patches so I can look if my current problems with loop-around are solved then? Regards, Steffen _____________________________________________________________________ Endlich SMS mit Bildern versenden! Das Bild selbst ist dabei gratis, Sie bezahlen lediglich den Versand. http://freemail.web.de/?mc=021195 _______________________________________________ Linux-streams mailing list [EMAIL PROTECTED] http://gsyc.escet.urjc.es/mailman/listinfo/linux-streams
