On Mon, Nov 22, 2021 at 06:35:58PM +0530, Jagan Teki wrote: > On Mon, Nov 22, 2021 at 3:38 PM Maxime Ripard <max...@cerno.tech> wrote: > > > > On Mon, Nov 22, 2021 at 12:22:20PM +0530, Jagan Teki wrote: > > > Get the display mode settings via mode_set bridge function > > > instead of explicitly de-reference. > > > > What's wrong with dereferencing the mode? > > Nothing wrong with dereferencing, however we have built-in API to that job.
That's not an API though? It's perfectly valid to dereference the pointer in atomic_enable, and that patch would consume memory for no particular reason. Maxime -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20211122132847.ds4gtk2unq3fkagy%40gilmour.