Re: [linux-sunxi] [PATCH RESEND v3] arm64: dts: allwinner: a64: olinuxino: Enable audio

['Philip Rinn' via linux-sunxi]

Hi,

On 13.01.22 at 07:59, Jernej Škrabec wrote:

Hi,

Dne sreda, 12. januar 2022 ob 16:29:51 CET je Philip Rinn napisal(a):

Hi,

On 12.01.22 at 10:09, Priit Laes wrote:

On Tue, Jan 11, 2022 at 09:08:23PM +0100, 'Philip Rinn' via linux-sunxi
wrote:

Enable the audio hardware on the Olimex A64-OLinuXino board family.
Tested on the A64-OLinuXino-2Ge8G-IND variant.

I have similar patch in one of my "long forgotten branches", but I'm not
100%
sure whether the cpvdd-supply is required for codec_analog. IIRC,
sound worked for me without the issues on A64-Olinuxino board (Rev D).

'cpvdd-supply = <&reg_eldo1>' for codec_analog

I didn't test it without but as it is present for all other a64 board with
audio and also in Olimex' tree I think it is needed.

It's not question if it works with or without it, nor if other boards have it
or not. Only deciding factor is board design. On schematic it can be seen that
cpvdd is connected to eldo1, so having this property is correct, mandatory
even.

Very true and it's easy to verify with the schematic available: 
https://raw.githubusercontent.com/OLIMEX/OLINUXINO/master/HARDWARE/A64-OLinuXino/1.%20Latest%20hardware%20revision/A64-OLinuXino%20hardware%20revision%20E/A64-OlinuXino_Rev_E.pdf

So from my point of view the patch is correct.

Best regards
Philip

Best regards,
Jernej

And we also need to enable these configuration options in the defconfig:

+CONFIG_SND_SUN8I_CODEC=m
+CONFIG_SND_SUN50I_CODEC_ANALOG=m

Hm, probably, but why wasn't it added when audio was added for the other a64
boards? Or are we talking about different defconfigs here?

Best regards
Philip

--
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
To view this discussion on the web, visit 
https://groups.google.com/d/msgid/linux-sunxi/8a19d309-af97-7ba7-87f6-8afb3905c9f6%40inventati.org.

OpenPGP_signature
Description: OpenPGP digital signature