Hi,
On 03/21/2014 08:39 PM, Olliver Schinagl wrote:
> David,
>
> can you confirm/deny this change makes sense? If so, can you give mnemoc the
> ok to go ahead with this fix?
>
> Olliver
>
> On 03/10/2014 02:58 AM, Wills Wang wrote:
>> ---
>> drivers/mmc/host/sunxi-mci.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sunxi-mci.h b/drivers/mmc/host/sunxi-mci.h
>> index 1447257..b885c32 100644
>> --- a/drivers/mmc/host/sunxi-mci.h
>> +++ b/drivers/mmc/host/sunxi-mci.h
>> @@ -35,7 +35,7 @@
>> #define MMC_MODCLK_PREFIX "sdc"
>> #define MMC3_DMA_TL (0x20070008)
>> #define MMC_MAX_DMA_DES_BIT 13
>> -#define MMC_DMA_DES_BIT_LEFT 5
>> +#define MMC_DMA_DES_BIT_LEFT 6
>> #endif
>>
>> /*---------- for sun5i ----------*/
The above chunk is correct, it will not matter functionally but the correct
value for MMC_DMA_DES_BIT_LEFT on sun4i is 6 not 5.
>> @@ -250,7 +250,7 @@
>> #define SDXC_IDMA_ERR (SDXC_IDMACFatalBusErr|SDXC_IDMACDesInvalid \
>> |SDXC_IDMACCardErrSum|SDXC_IDMACAbnormalIntSum)
>>
>> -#define SDXC_DES_NUM_SHIFT (MMC_MAX_DMA_DES_BIT)
>> +#define SDXC_DES_NUM_SHIFT (MMC_MAX_DMA_DES_BIT - 1)
>> #define SDXC_DES_BUFFER_MAX_LEN (1U << SDXC_DES_NUM_SHIFT)
>> struct sunxi_mmc_idma_des {
>> u32 config;
This chunk is non-sense and should not I repeat NOT be applied.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
