Hi, On Fri, May 02, 2014 at 01:45:04PM +0200, Zoltan HERPAI wrote: > This patch will add a basic board support DT for the > LinkSprite pcDuino V3, which is based on A20. > > Signed-off-by: Zoltan HERPAI <wigy...@uid0.hu> > --- > arch/arm/boot/dts/Makefile | 3 +- > arch/arm/boot/dts/sun7i-a20-pcduino3.dts | 70 > ++++++++++++++++++++++++++++++ > 2 files changed, 72 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/boot/dts/sun7i-a20-pcduino3.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 1cd137d..821fa99 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -354,7 +354,8 @@ dtb-$(CONFIG_ARCH_SUNXI) += \ > sun6i-a31-m9.dtb \ > sun7i-a20-cubieboard2.dtb \ > sun7i-a20-cubietruck.dtb \ > - sun7i-a20-olinuxino-micro.dtb > + sun7i-a20-olinuxino-micro.dtb \ > + sun7i-a20-pcduino3.dtb > dtb-$(CONFIG_ARCH_TEGRA) += tegra20-harmony.dtb \ > tegra20-iris-512.dtb \ > tegra20-medcom-wide.dtb \ > diff --git a/arch/arm/boot/dts/sun7i-a20-pcduino3.dts > b/arch/arm/boot/dts/sun7i-a20-pcduino3.dts > new file mode 100644 > index 0000000..bf9d527 > --- /dev/null > +++ b/arch/arm/boot/dts/sun7i-a20-pcduino3.dts > @@ -0,0 +1,70 @@ > +/* > + * Copyright 2014 Zoltan HERPAI > + * Zoltan HERPAI <wigy...@uid0.hu> > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > +/dts-v1/; > +/include/ "sun7i-a20.dtsi" > +/include/ "sunxi-common-regulators.dtsi" > +#include <dt-bindings/input/input.h>
I don't think you're using it anywhere.
> +
> +/ {
> + model = "LinkSprite pcDuino V3";
> + compatible = "linksprite,a20-pcduino3", "allwinner,sun7i-a20";
> +
> + soc@01c00000 {
> + pinctrl@01c20800 {
> + led_pins_pcduino3: led_pins@0 {
> + allwinner,pins = "PH2";
> + allwinner,function = "gpio_out";
> + allwinner,drive = <1>;
> + allwinner,pull = <0>;
> + };
> + };
> +
> + uart0: serial@01c28000 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pins_a>;
> + status = "okay";
> + };
> +
> + i2c0: i2c@01c2ac00 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pins_a>;
> + status = "okay";
> + #address-cells = <1>;
> + #size-cells = <0>;
You're missing a closing bracket here. Make sure to compile your DT
whenever you're submitting it.
Apart from that it looks good. The next two patches can be merged with
this one however.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
