On Sun, 18 May 2014 12:49:51 +0300
gamis...@gmail.com wrote:
Thanks for taking "git send-email" into use. That's a clear
progress. However some things are still not quite right.
> From: HeHoPMaJIeH <hehopmaj...@debian.bg>
Who is HeHoPMaJIeH?
The real names of the contributors *must* be used if this is ever going
to go into the upstream u-boot:
http://lists.denx.de/pipermail/u-boot/2014-March/175925.html
The "Signed-off-by" tag in the commit message is also *strictly*
required. It means among other things that you are legally authorized
to do this contribution and also can assure the code quality (to the
best of your knowledge).
The commit message is completely missing in your patch. If you look at
it, this patch has no Olimex references whatsoever. Nobody is going
have any clue about what kind of device is that supposed to be after
just looking at the patch. Please have a look at an example of a
proper patch, which is also adding a new device support:
https://github.com/linux-sunxi/u-boot-sunxi/commit/0328ccce1339
The "A13-SOM" is a generic name. Maybe it is OK. Or maybe it would
be nice to somehow put it under the "Olimex" namespace to clearly
differentiate from the things like https://aw-som.com/
I don't have a really strong opinion about this myself. If Olimex is
the first, then it might be fine for it to grab the generic name for
itself. But I would like to hear what the other people think about
it. Hello? Anyone?
To sum it up. The patch still needs to be reworked. There is no other
way. Either you send a fixed version, or Hans might be kind enough to
do all the corrections himself and add his own "Signed-off-by" tag,
just to save time. If that happens, please understand that you owe
Hans a glass beer, or maybe more :-)
One more thing. When sending patches for the u-boot-sunxi, it is better
to have "[PATCH u-boot-sunxi]" instead of just "[PATCH]" in the
e-mail subject line.
Thanks again for your hard work towards having full out-of-the-box
support for this new Olimex hardware under the linux-sunxi umbrella.
>
> ---
> board/sunxi/Makefile | 1 +
> board/sunxi/dram_a13_som.c | 32 ++++++++++++++++++++++++++++++++
> boards.cfg | 1 +
> 3 files changed, 34 insertions(+)
> create mode 100644 board/sunxi/dram_a13_som.c
>
> diff --git a/board/sunxi/Makefile b/board/sunxi/Makefile
> index bd15e16..aa9bff7 100644
> --- a/board/sunxi/Makefile
> +++ b/board/sunxi/Makefile
> @@ -73,3 +73,4 @@ obj-$(CONFIG_WOBO_I5) += dram_wobo_i5.o
> obj-$(CONFIG_XZPAD700) += dram_xzpad700.o
> obj-$(CONFIG_ZATAB) += dram_zatab.o
> obj-$(CONFIG_MERRII_M2) += dram_merrii_m2.o
> +obj-$(CONFIG_A13_SOM) += dram_a13_som.o
> diff --git a/board/sunxi/dram_a13_som.c b/board/sunxi/dram_a13_som.c
> new file mode 100644
> index 0000000..b6e57e7
> --- /dev/null
> +++ b/board/sunxi/dram_a13_som.c
> @@ -0,0 +1,32 @@
> +/* this file is generated, don't edit it yourself */
> +
> +#include <common.h>
> +#include <asm/arch/dram.h>
> +
> +static struct dram_para dram_para = {
> + .clock = 408,
> + .type = 3,
> + .rank_num = 1,
> + .density = 4096,
> + .io_width = 16,
> + .bus_width = 16,
> + .cas = 9,
> + .zq = 123,
> + .odt_en = 0,
> + .size = 512,
> + .tpr0 = 0x42d899b7,
> + .tpr1 = 0xa090,
> + .tpr2 = 0x22a00,
> + .tpr3 = 0,
> + .tpr4 = 0,
> + .tpr5 = 0,
> + .emr1 = 0,
> + .emr2 = 0x10,
> + .emr3 = 0,
> +
> +};
> +
> +unsigned long sunxi_dram_init(void)
> +{
> + return dramc_init(&dram_para);
> +}
> diff --git a/boards.cfg b/boards.cfg
> index c3b35b6..1daa157 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -454,6 +454,7 @@ Active arm armv7 sunxi -
> sunxi
> Active arm armv7 sunxi - sunxi
> wobo-i5 sun5i:WOBO_I5,SPL,STATUSLED=34
>
> -
> Active arm armv7 sunxi - sunxi
> xzpad700 sun5i:XZPAD700,SPL
>
> -
> Active arm armv7 sunxi - sunxi
> zatab sun4i:ZATAB,SPL
>
> -
> +Active arm armv7 sunxi - sunxi
> A13-SOM
> sun5i:A13_SOM,SPL,NO_AXP,STATUSLED=201,CONS_INDEX=2
> Active arm armv7 u8500 st-ericsson snowball
> snowball -
>
> Mathieu Poirier <mathieu.poir...@linaro.org>
> Active arm armv7 u8500 st-ericsson u8500
> u8500_href -
>
> -
> Active arm armv7 vf610 freescale vf610twr
> vf610twr
> vf610twr:IMX_CONFIG=board/freescale/vf610twr/imximage.cfg
> Alison Wang
> <b18...@freescale.com>
--
Best regards,
Siarhei Siamashka
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
