On Mon, Oct 20, 2014 at 10:33:14PM +0200, Bruno Prémont wrote: > > ---
You're missing a commit log, and your signed-off-by. You should go through Documentation/SubmittingPatches, and make sure to run checkpatch.pl, and fix the warning and errors. > Note: the OCV values seem to have some defaults build into the > PMIC though may need adjustment if the used battery has a different > open circuit voltage curve. > As far as understood (these values are set in vendor driver but not > mentioned in chip documentation) they represent charge percentage > for some predefined voltages. > > If prefixing these values with "x-power," is preferred the following > patch should becomes a dependency: > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/267606.html Feel free to fold that patch into your serie, since it seems to have been forgotten. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
signature.asc
Description: Digital signature
