Hi Danny, You commit message needs some work.
Firstly the title should be a little more descriptive, maybe something like sun4i-codec: Add FM, Line and Mic inputs On Tue, Dec 8, 2015 at 2:48 PM, Danny Milosavljevic <dan...@scratchpost.org> wrote: > Hi, > > this is the fifth version of the patch that adds inputs to sun4i-codec. > (Previous versions have been on the linux-sunxi mailing list only, > but this one went to the maintainers as well, > Message-Id: 20151208042013.11d31f09 () dayas) The salutation and info about previous versions being sunxi mailing list only should go beneath the three dashes. > The inputs added are: > - FM-In Left and Right > - Line-In Left and Right > - Mic1-In > - Mic2-In This needs to be reformatted to better describe what's happening in tht > Changes compared to v4 are: > - Mic preamplifier controls have more common names now. > - Mic preamplifier scale has a 0 dB entry as well now, as documented in the > A20 user manual. > - Mic preamplifier has special cases for A20 and A10 now. > - Gain controls have "Gain" in the name now. > > I successfully tested it on an A20 board using alsamixer, headphones, a radio > and > my ears. > Note that because of missing capturing support I tested only the mixing, > for Mic, Line, and FM. > > The patches are on top of > <git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git>, > branch "sunxi/for-next". > > Regards, > Danny > > Danny (1): > b/sound/soc/sunxi/sun4i-codec.c | 153 > +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 150 insertions(+), 3 deletions(-) The changelog, testing notes, source info and diffstat should also be below the three dashes. > Signed-off-by: Danny Milosavljevic <danny...@scratchpost.org> > --- So reformatting it, you'd get something like this: ------>8------ Subject: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs Add inputs to sun4i-codec: - FM-in Left and Right - Line-in Left and Right - Mic1-in - Mic2-in Signed-off-by: Danny ....... --- Hi, this is the fifth version of the patch that adds inputs to sun4i-codec. (Previous versions have been on the linux-sunxi mailing list only, but this one went to the maintainers as well, Message-Id: 20151208042013.11d31f09 () dayas) Changes compared to v4 are: - Mic preamplifier controls have more common names now. - Mic preamplifier scale has a 0 dB entry as well now, as documented in the A20 user manual. - Mic preamplifier has special cases for A20 and A10 now. - Gain controls have "Gain" in the name now. I successfully tested it on an A20 board using alsamixer, headphones, a radio and my ears. Note that because of missing capturing support I tested only the mixing, for Mic, Line, and FM. The patches are on top of <git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git>, branch "sunxi/for-next". Regards, Danny Danny (1): b/sound/soc/sunxi/sun4i-codec.c | 153 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 150 insertions(+), 3 deletions(-) ------>8------ Thanks, -- Julian Calaby Email: julian.cal...@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
