Hi Jagan, thanks for the review!
On 03/02/17 11:04, Jagan Teki wrote: > On Wed, Feb 1, 2017 at 2:36 AM, Andre Przywara <andre.przyw...@arm.com> wrote: >> Traditionally Allwinner SoCs have their boot ROM mapped just below 4GB, >> while the first SRAM region is mapped at address 0. >> With the extended physical memory support of the A80 this was changed, >> so the BROM is now at address 0 and the SRAM region starts right behind >> this at 64KB. This configuration seems to be called "high SRAM". >> Instead of enumerating the SoCs which have copied this configuration, >> let's call a spade a spade and introduce a Kconfig option for this setup. >> SoCs implementing this (A80, A64 and H5, so far), can then select this >> configuration. >> Simplify the config header definition on the way. >> >> Signed-off-by: Andre Przywara <andre.przyw...@arm.com> >> Acked-by: Maxime Ripard <maxime.rip...@free-electrons.com> >> --- >> arch/arm/include/asm/arch-sunxi/spl.h | 2 +- >> board/sunxi/Kconfig | 6 ++++++ >> include/configs/sunxi-common.h | 19 +++++++------------ >> 3 files changed, 14 insertions(+), 13 deletions(-) >> >> diff --git a/arch/arm/include/asm/arch-sunxi/spl.h >> b/arch/arm/include/asm/arch-sunxi/spl.h >> index 5d7ab55..831d0c0 100644 >> --- a/arch/arm/include/asm/arch-sunxi/spl.h >> +++ b/arch/arm/include/asm/arch-sunxi/spl.h >> @@ -12,7 +12,7 @@ >> #define SPL_SIGNATURE "SPL" /* marks "sunxi" SPL header */ >> #define SPL_HEADER_VERSION 1 >> >> -#if defined(CONFIG_MACH_SUN9I) || defined(CONFIG_MACH_SUN50I) >> +#ifdef CONFIG_SUNXI_HIGH_SRAM >> #define SPL_ADDR 0x10000 >> #else >> #define SPL_ADDR 0x0 >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig >> index ea0d658..688cb12 100644 >> --- a/board/sunxi/Kconfig >> +++ b/board/sunxi/Kconfig >> @@ -27,6 +27,10 @@ config SPL_POWER_SUPPORT >> config SPL_SERIAL_SUPPORT >> default y >> >> +config SUNXI_HIGH_SRAM >> + bool >> + default n > > Write some help text, once written I wanted originally, but then saw that none of the invisible options (no text after bool) have a help text, mainly because it will probably never be shown. I can still add some help text here for documentation purposes, or in some other place. Or leave it up for the commit message to cover that. Cheers, Andre. > > Reviewed-by: Jagan Teki <ja...@openedev.com> > > thanks! > -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.