On Thu, May 04, 2017 at 11:51:19AM +0200, Olliver Schinagl wrote: > Hey Maxime, > > On 04-05-17 11:43, Maxime Ripard wrote: > > Hi, > > > > On Thu, May 04, 2017 at 11:00:31AM +0200, Olliver Schinagl wrote: > > > Sync the sun7i-a20-olinuxino-lime2-emmc.dts with the upstream kernel, > > > which fixes the power-sequencing pin being wrongfully set up. > > > > You have a dependency between two patches. The usual way to deal with > > that is to create a serie of patches so that they all work. Or at > > least mentionning it. > > Well, I do not have a dependancy per-say. The dts was al ready there. The > problem is some people have reported problems with the power sequencing > sometimes not working properly for them.
You said in your note that it wasn't working properly without that patch. That definitely looks like a dependency to me. > > And you should also explain what was wrongfully set up. There's > > nothing obvious from the patch below. > > You are right, it was just a sync from the upstream dt. It wasn't "just a sync" if it was fixing an issue. > Which is why I asked, how do we normally handle it, just copy/paste and make > a patch was the answer there. > > I think we need a better system as to keeping the device tree's in sync, if > we want both to use the same device-tree, right? This one works just fine. You just have to describe properly what you're doing in your commit log. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
