On Mon, May 15, 2017 at 10:02:20AM +0200, Olliver Schinagl wrote: > We currently have a few dependencies explicitly set in the sunxi > defconfigs. Things such as, RGMII, DESIGNWARE_ETH in combination with > SUN7I_GMAC. When selecting SUN7I_GMAC we already imply DESIGNWARE_ETH > for example. > > This patch puts this logic into the Kconfig thus simplifying the > defconfigs. For a user it is also no more logical when enabling one of > the drivers in Kconfig to have the proper dependencies automatically > selected. > > One thing to note, the sun7i driver can be connected in two modes, > RGMII and MII mode and we use both throughout the boards. To make this > easy we split up the CONFIG_SUNXI_GMAC symbol into the SUN7I_GMAC and > the SUN7I_EMAC symbol, where the SUN7I_EMAC indicates a MII connected > designware IP.
This doesn't make any sense. You have two *separate* blocks on the A20, the EMAC and the GMAC, and yet, you want SUN7I_EMAC to not represent the EMAC found, but the GMAC with an MII phy? The current configuration we have is fine as it is, there's no need to change it, especially for something that is so confusing. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
