Hi Andre, On Wed, May 16, 2018 at 09:00:50AM +0100, Andre Przywara wrote: > The Pine64-LTS board is a new board version of the Pine64, though > actually it's a non-SoM version of the SoPine and its baseboard. > In contrast to the original Pine64 it features LPDDR3 DRAM, an eMMC > socket and a SPI flash chip for storing firmware (like U-Boot). > Add it as a variant to the existing SoPine defconfig, since from a > software point of view they are really not different. > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com>
I'm mostly fine with the changes you made, there's just one thing that worries me a bit: the discoverability of the defconfig is pretty bad. If you don't know it already, it's very difficult to see that the defconfig you should use for the Pine64 LTS is the SoPine Baseboard one. Maybe we can add a symbolic link from the pine64_lts_defconfig to the sopine one to make that obvious? The bonus would be that if we ever need to split them for whatever reason, we can do that without breaking each and every user setup. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
