Hello Maxime,

On Mon, Apr 01, 2019 at 08:30:49AM +0200, Maxime Ripard wrote:
> Hi,
> 
> On Wed, Mar 27, 2019 at 01:18:38AM +0100, meg...@megous.com wrote:
> > From: Ondrej Jirman <meg...@megous.com>
> >
> > A711 tablet has BMA250 accelerometer connected to I2C1 bus. Enable
> > both the I2C1 bus and add the accelerometer device to it.
> >
> > Signed-off-by: Ondrej Jirman <meg...@megous.com>
> > ---
> >  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts 
> > b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > index 6aae70c89a1e..347fc0c31fa4 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> > @@ -156,6 +156,21 @@
> >     status = "okay";
> >  };
> >
> > +&i2c1 {
> > +   pinctrl-names = "default";
> > +   pinctrl-0 = <&i2c1_pins>;
> 
> It's there already

I see, I'll drop it. Thanks.

> > +   clock-frequency = <400000>;
> > +   status = "okay";
> > +
> > +   /* Accelerometer */
> > +   bma250@18 {
> 
> The node name should be the class of the device, not its model, so
> something like accelerometer.

I'll rename this.

thank you,
  Ondrej

> Maxime
> 
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com


-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to