Hi, On Tue, 4 Jun 2019 at 16:54, Ondřej Jirman <meg...@megous.com> wrote: > > On Tue, May 28, 2019 at 06:14:31PM +0200, Clément Péron wrote: > > Allwiner A31 has a different memory mapping so add the compatible > > we will need it later. > > > > Signed-off-by: Clément Péron <peron.c...@gmail.com> > > --- > > drivers/media/rc/sunxi-cir.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c > > index d02dcb6fd0a5..0504ebfc831f 100644 > > --- a/drivers/media/rc/sunxi-cir.c > > +++ b/drivers/media/rc/sunxi-cir.c > > @@ -343,6 +343,11 @@ static const struct sunxi_ir_quirks > > sun5i_a13_ir_quirks = { > > .fifo_size = 64, > > }; > > > > +static const struct sunxi_ir_quirks sun6i_a31_ir_quirks = { > > + .has_reset = true, > > + .fifo_size = 64, > > +}; > > + > > BTW, H6 BSP uses FIFO size 40: > > https://github.com/orangepi-xunlong/OrangePiH6_Linux4_9/blob/master/drivers/media/rc/sunxi-ir-dev.c#L290 > > Have you tried filling the fifo with over 40 words on H6, to see if it works? No I didn't try this, but I trust more the user manual than the driver. And I don't see why they would have reduce the fifo size in the new generation. Anyway, I will be able to test that at the end of the week.
Regards, Clément > I know it's docummented as having 64 words in the manual, so maybe Allwiner > just didn't care enough to make the driver configurable, and the H6 > FIFO really has that depth. > > regards, > o. > > > static const struct of_device_id sunxi_ir_match[] = { > > { > > .compatible = "allwinner,sun4i-a10-ir", > > @@ -352,6 +357,10 @@ static const struct of_device_id sunxi_ir_match[] = { > > .compatible = "allwinner,sun5i-a13-ir", > > .data = &sun5i_a13_ir_quirks, > > }, > > + { > > + .compatible = "allwinner,sun6i-a31-ir", > > + .data = &sun6i_a31_ir_quirks, > > + }, > > {} > > }; > > MODULE_DEVICE_TABLE(of, sunxi_ir_match); > > -- > > 2.20.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-ker...@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CAJiuCceqATLiDjpNLTq%2BgOhUHun40udJdpXYirn%3DZ%3DGVQLQzaw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.