Hi Corentin, On Fri, 2019-10-25 at 20:51 +0200, Corentin Labbe wrote: > The Security System is an hardware cryptographic offloader present > on Allwinner SoCs A80 and A83T. > It is different from the previous sun4i-ss. > > This driver supports AES cipher in CBC and ECB mode. > > Acked-by: Maxime Ripard <mrip...@kernel.org> > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> > --- [...] > +static int sun8i_ss_probe(struct platform_device *pdev) > +{ > + struct sun8i_ss_dev *ss; > + int err, irq; > + u32 v; > + > + ss = devm_kzalloc(&pdev->dev, sizeof(*ss), GFP_KERNEL); > + if (!ss) > + return -ENOMEM; [...] > + > + ss->reset = devm_reset_control_get(&pdev->dev, NULL);
It looks like this driver could use devm_reset_control_get_shared() to get a (clk-like) refcounted reset control. Otherwise, please use devm_reset_control_get_exclusive() instead of devm_reset_control_get(). See the kerneldoc comment for reset_control_get_shared() for details. regards Philipp -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/7bbd6c77117d2391f6669a9eb958730717ea295c.camel%40pengutronix.de.