On Fri, Sep 04, 2020 at 12:37:19PM -0700, Joe Perches wrote: > On Fri, 2020-09-04 at 11:10 +0000, Corentin Labbe wrote: > > This patch fix a double empty line issue reported by checkpatch. > > While at it, since now the maximum line length is now 100, reorder some > > wrapped line. > [] > > diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > > b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c > [] > > @@ -164,12 +164,10 @@ static int sun8i_ce_cipher_prepare(struct > > crypto_engine *engine, void *async_req > > goto theend_key; > > } > > offset = areq->cryptlen - ivsize; > > - scatterwalk_map_and_copy(rctx->backup_iv, areq->src, > > - offset, ivsize, 0); > > + scatterwalk_map_and_copy(rctx->backup_iv, areq->src, > > offset, ivsize, 0); > > } > > memcpy(rctx->bounce_iv, areq->iv, ivsize); > > - addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, > > - DMA_TO_DEVICE); > > + addr_iv = dma_map_single(ce->dev, rctx->bounce_iv, rctx->ivlen, > > DMA_TO_DEVICE); > > coding-style.rst: > > Statements longer than 80 columns should be broken into sensible chunks, > unless exceeding 80 columns significantly increases readability and does > not hide information. > > Do these longer lines make the code significantly more readable? > I don't think they do. >
Oh I saw the increase in checkpatch.pl but didnt saw that it was still 80 in coding-style.rst. Anyway as maintainer of this driver, I prefer unwrapped lines. I let Herbert to choose to apply the serie without this last patch or not. -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/20200907071617.GA11894%40Red.
