在 2020-10-25星期日的 00:25 +0800,Chen-Yu Tsai写道: > From: Chen-Yu Tsai <w...@csie.org> > > The Ethernet PHY on the A31 Hummingbird has the RX and TX delays > enabled on the PHY, using pull-ups on the RXDLY and TXDLY pins. > > Fix the phy-mode description to correct reflect this so that the > implementation doesn't reconfigure the delays incorrectly. This > happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e > rx/tx delay config").
Personally I think they should revert this commit, and consider other solution. This commit breaks everything. (Although the patch on individual DT patches are technically correct) > > Fixes: c220aec2bb79 ("ARM: dts: sun6i: Add Merrii A31 Hummingbird > support") > Signed-off-by: Chen-Yu Tsai <w...@csie.org> > --- > arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts > b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts > index 049e6ab3cf56..73de34ae37fd 100644 > --- a/arch/arm/boot/dts/sun6i-a31-hummingbird.dts > +++ b/arch/arm/boot/dts/sun6i-a31-hummingbird.dts > @@ -154,7 +154,7 @@ &gmac { > pinctrl-names = "default"; > pinctrl-0 = <&gmac_rgmii_pins>; > phy-handle = <&phy1>; > - phy-mode = "rgmii"; > + phy-mode = "rgmii-id"; > status = "okay"; > }; > > -- > 2.28.0 > -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/79894e1266db69e463ee74a52551101298cae03e.camel%40aosc.io.