> From: Mark Brown [mailto:[email protected]] > Sent: Thursday, January 05, 2012 11:59 AM
Thanks for feedback. I have taken care of all your feedback and send the patch V2. > > + /* Configure the output discharge path */ > > + st = tps62360_reg_modify_bits(tps, REG_RAMPCTRL, BIT(2), BIT(2)); > > + if (st < 0) > > + dev_err(tps->dev, "%s() fails in updating reg %d\n", > > + __func__, REG_RAMPCTRL); > > +} > > I rather suspect that if this is worth doing it's also worth doing over > suspend... The discharge path should be only enabled when the output voltage will go to 0. If it stay in non-zero voltage and enabling discharge path will consume more power. In suspend, it is not necessarily that voltage output will be 0 and hence it should not be enabled. In shutdown all power goes off from pmu and hence it is worth to enable discharge path for quick fall of output voltage. > > > + * @vsel: Select the voltage id register. > > What's this? There is 4 sets of voltage configuration register for voltage output. The power on reset values for this registers are different and selection of the voltage configuration register is done by 2 pins of the pmu chip which is board dependent. Based on board connection, it need to be program the desired voltage configuration Register to achieve the desired output. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
