On 01/17/2013 08:53 AM, Peter De Schrijver wrote: > On Wed, Jan 16, 2013 at 09:52:53PM +0100, Stephen Warren wrote: >> From: Prashant Gaikwad <[email protected]> >> >> Add Tegra specific clocks, pll, pll_out, peripheral, frac_divider, super. >> >> Signed-off-by: Prashant Gaikwad <[email protected]> >> [swarren: alloc sizeof(*foo) not sizeof(struct foo), add comments re: >> storing pointers to stack variables, make a timeout loop more idiomatic, >> use _clk_pll_disable() not clk_disable_pll() from _program_pll() to >> avoid redundant lock operations, unified tegra_clk_periph() and >> tegra_clk_periph_nodiv(), unified tegra_clk_pll{,e}, rename all clock >> registration functions so they don't have the same name as the clock >> structs.] >> Signed-off-by: Stephen Warren <[email protected]> > > ... > >> +static int clk_plle_enable(struct clk_hw *hw) >> +{ >> + struct tegra_clk_pll *pll = to_clk_pll(hw); >> + unsigned long input_rate = clk_get_rate(clk_get_parent(hw->clk)); >> + struct tegra_clk_pll_freq_table sel; >> + u32 val; >> + int err; >> + >> + if (_get_table_rate(hw, &sel, pll->fixed_rate, input_rate)) >> + return -EBUSY; >> + > > I think -EINVAL would be more appropriate here?
Yes. I fixed this and the PLL function parameters you mentioned in your other email. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
