On Mon, Aug 26, 2013 at 11:30:51AM -0400, Kyle McMartin wrote: > While poking at something using the for-3.12/* trees, I hit the > following compile error: > drivers/built-in.o: In function `tegra_pcie_map_irq': > /builddir/build/BUILD/kernel-3.10.fc20/linux-3.11.0-0.rc6.git4.1.fc20.armv7hl/drivers/pci/host/pci-tegra.c:640: > undefined reference to `tegra_cpuidle_pcie_irqs_in_use' > drivers/built-in.o: In function `tegra_msi_map': > /builddir/build/BUILD/kernel-3.10.fc20/linux-3.11.0-0.rc6.git4.1.fc20.armv7hl/drivers/pci/host/pci-tegra.c:1227: > undefined reference to `tegra_cpuidle_pcie_irqs_in_use' > make: *** [vmlinux] Error 1 > > Since our .config had CONFIG_CPU_IDLE off. We should probably provide > an empty function to handle this to avoid cluttering up pci-tegra.c > with conditionals. > > Signed-off-by: Kyle McMartin <[email protected]> > > --- a/include/linux/tegra-cpuidle.h > +++ b/include/linux/tegra-cpuidle.h > @@ -14,6 +14,13 @@ > #ifndef __LINUX_TEGRA_CPUIDLE_H__ > #define __LINUX_TEGRA_CPUIDLE_H__ > > +#ifdef CONFIG_CPU_IDLE > void tegra_cpuidle_pcie_irqs_in_use(void); > +#else > +static inline void tegra_cpuidle_pcie_irqs_in_use(void) > +{ > + return;
There's technically no need for this return statement, but either way the patch looks good, so: Reviewed-by: Thierry Reding <[email protected]>
pgpE7muUhppng.pgp
Description: PGP signature
