On Sat, 02 Mar 2024 06:02:22 +0900, Geert Uytterhoeven wrote: > > arch/sh/boot/compressed/cache.c:2:5: warning: no previous prototype for > ‘cache_control’ [-Wmissing-prototypes] > arch/sh/boot/compressed/misc.c:115:6: warning: no previous prototype for > ‘ftrace_stub’ [-Wmissing-prototypes] > arch/sh/boot/compressed/misc.c:118:6: warning: no previous prototype for > ‘arch_ftrace_ops_list_func’ [-Wmissing-prototypes] > arch/sh/boot/compressed/misc.c:128:6: warning: no previous prototype for > ‘decompress_kernel’ [-Wmissing-prototypes] > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> > --- > arch/sh/boot/compressed/cache.c | 3 +++ > arch/sh/boot/compressed/cache.h | 10 ++++++++++ > arch/sh/boot/compressed/misc.c | 8 +++----- > arch/sh/boot/compressed/misc.h | 9 +++++++++ > 4 files changed, 25 insertions(+), 5 deletions(-) > create mode 100644 arch/sh/boot/compressed/cache.h > create mode 100644 arch/sh/boot/compressed/misc.h > > diff --git a/arch/sh/boot/compressed/cache.c b/arch/sh/boot/compressed/cache.c > index 31e04ff4841ed084..95c1e73ccbb7e011 100644 > --- a/arch/sh/boot/compressed/cache.c > +++ b/arch/sh/boot/compressed/cache.c > @@ -1,4 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > + > +#include "cache.h" > + > int cache_control(unsigned int command) > { > volatile unsigned int *p = (volatile unsigned int *) 0x80000000; > diff --git a/arch/sh/boot/compressed/cache.h b/arch/sh/boot/compressed/cache.h > new file mode 100644 > index 0000000000000000..b622b68c87f59b97 > --- /dev/null > +++ b/arch/sh/boot/compressed/cache.h > @@ -0,0 +1,10 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef CACHE_H > +#define CACHE_H > + > +#define CACHE_ENABLE 0 > +#define CACHE_DISABLE 1 > + > +int cache_control(unsigned int command); > + > +#endif /* CACHE_H */ > diff --git a/arch/sh/boot/compressed/misc.c b/arch/sh/boot/compressed/misc.c > index ca05c99a3d5b488d..5178150ca6650dcf 100644 > --- a/arch/sh/boot/compressed/misc.c > +++ b/arch/sh/boot/compressed/misc.c > @@ -16,6 +16,9 @@ > #include <asm/addrspace.h> > #include <asm/page.h> > > +#include "cache.h" > +#include "misc.h" > + > /* > * gzip declarations > */ > @@ -26,11 +29,6 @@ > #undef memcpy > #define memzero(s, n) memset ((s), 0, (n)) > > -/* cache.c */ > -#define CACHE_ENABLE 0 > -#define CACHE_DISABLE 1 > -int cache_control(unsigned int command); > - > extern char input_data[]; > extern int input_len; > static unsigned char *output; > diff --git a/arch/sh/boot/compressed/misc.h b/arch/sh/boot/compressed/misc.h > new file mode 100644 > index 0000000000000000..2b4534faa3052857 > --- /dev/null > +++ b/arch/sh/boot/compressed/misc.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef MISC_H > +#define MISC_H > + > +void arch_ftrace_ops_list_func(void); > +void decompress_kernel(void); > +void ftrace_stub(void); > + > +#endif /* MISC_H */ > -- > 2.34.1 > >
This cache control is from SH5, so it is no longer needed. I think it's better to simply delete chace.c and cache_control. -- Yosinori Sato