On 22/04/2024 11:17, Jason Xing wrote:> On Mon, Apr 22, 2024 at 4:47 PM Matthieu Baerts <matt...@kernel.org> wrote: >> On 22/04/2024 05:01, Jason Xing wrote: >>> From: Jason Xing <kernelx...@tencent.com>
(...) >>> diff --git a/include/net/rstreason.h b/include/net/rstreason.h >>> new file mode 100644 >>> index 000000000000..c57bc5413c17 >>> --- /dev/null >>> +++ b/include/net/rstreason.h >>> @@ -0,0 +1,144 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >>> + >>> +#ifndef _LINUX_RSTREASON_H >>> +#define _LINUX_RSTREASON_H >>> +#include <net/dropreason-core.h> >>> +#include <uapi/linux/mptcp.h> >>> + >>> +#define DEFINE_RST_REASON(FN, FNe) \ >>> + FN(MPTCP_RST_EUNSPEC) \ >>> + FN(MPTCP_RST_EMPTCP) \ >>> + FN(MPTCP_RST_ERESOURCE) \ >>> + FN(MPTCP_RST_EPROHIBIT) \ >>> + FN(MPTCP_RST_EWQ2BIG) \ >>> + FN(MPTCP_RST_EBADPERF) \ >>> + FN(MPTCP_RST_EMIDDLEBOX) \ >> >> Small detail: should it not make more sense to put the ones linked to >> MPTCP at the end? I mean I guess MPTCP should be treated in second >> priority: CONFIG_MPTCP could not be set, and the ones linked to TCP >> should be more frequent, etc. > > Do you mean that I need to adjust the order: 1) tcp reasons first, 2) > independent reasons, 3) mptcp reasons ? Correct, it looks like it is a more "natural" order. > Reasonable. I will do it :) Thanks! Cheers, Matt -- Sponsored by the NGI0 Core fund.
