On Tue, Aug 13, 2024 at 2:36 PM Tomas Glozar <tglo...@redhat.com> wrote:
>
> út 13. 8. 2024 v 13:49 odesílatel Eder Zulian <ezul...@redhat.com> napsal:
> >
> > In addition, fix a typo in the error message generated when the
> > specified duration is invalid.
> >
> > Signed-off-by: Eder Zulian <ezul...@redhat.com>
> > ---
> > tools/tracing/rtla/src/osnoise_hist.c | 4 ++--
> > tools/tracing/rtla/src/timerlat_hist.c | 4 ++--
> > 2 files changed, 4 insertions(+), 4 deletions(-)
> >
>
> FYI some of the issues you fixed for hist are also in timerlat_top.c:
>
> " -d/--duration time[m|h|d]: duration of the session in seconds",
> ...
> case 'd':
> params->duration = parse_seconds_duration(optarg);
> if (!params->duration)
> timerlat_top_usage("Invalid -D duration\n");
> break;
>
> and the "Invalid -D duration" (instead of "-d") one is also in
> osnoise_top.c. Those would probably go to a separate patch, though.
I followed your suggestion and submitted it as
https://lore.kernel.org/linux-trace-kernel/20240813155831.384446-1-ezul...@redhat.com/T/#u
>
> Reviewed-by: Tomas Glozar <tglo...@redhat.com>
>
>
> Tomas
>
Thank you, Tomas.
