On Mon, Sep 16, 2024 at 12:29:30PM -0400, Steven Rostedt wrote: > On Mon, 16 Sep 2024 14:16:56 +0200 > Heiko Carstens <h...@linux.ibm.com> wrote: > > > This does not pass the ftrace selftests. Please merge the patch below > > into this patch. With that: > > > > Acked-by: Heiko Carstens <h...@linux.ibm.com> > > Thank you very much, this is why I wanted arch maintainers acks before > taking anything. > > There may be other patches in this series that I didn't Cc everyone > (yet). Did you look at the other patches? If not, I'll go and do the Cc. > It's a manual process.
I just had a quick look and tried Masami's git tree with the topic/fprobe-on-fgraph branch and tried the ftrace selftests, which resulted in the provided small fix. But now that you ask, I can see that FPROBE is not available on s390 anymore with the full series, since HAVE_FTRACE_GRAPH_FUNC is not available. Also the s390 variant of arch_ftrace_fill_perf_regs() seems to be incorrect. Looks like some work is needed from our side.