On Thu, 20 Mar 2025, Tomas Glozar wrote:
> Add function to test engine to test with pre-set osnoise options, and
> use it to test whether osnoise period (as an example) is set correctly.
>
> The test works by pre-setting a high period of 10 minutes and stop on
> threshold. Thus, it is easy to check whether rtla is properly resetting
> the period to default: if it is, the test will complete on time, since
> the first sample will overflow the threshold. If not, it will time out.
>
> Signed-off-by: Tomas Glozar <[email protected]>
> ---
> tools/tracing/rtla/tests/engine.sh | 26 ++++++++++++++++++++++++++
> tools/tracing/rtla/tests/osnoise.t | 6 ++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/tools/tracing/rtla/tests/engine.sh
> b/tools/tracing/rtla/tests/engine.sh
> index 5db8aa4bc031..b1697b3e3f52 100644
> --- a/tools/tracing/rtla/tests/engine.sh
> +++ b/tools/tracing/rtla/tests/engine.sh
> @@ -61,6 +61,32 @@ check() {
> fi
> }
>
> +check_with_osnoise_options() {
> + # Do the same as "check", but with pre-set osnoise options.
> + # Note: rtla should reset the osnoise options, this is used to test
> + # if it indeed does so.
> + # Save original arguments
> + arg1=$1
> + arg2=$2
> +
> + # Apply osnoise options (if not dry run)
> + if [ -n "$TEST_COUNT" ]
> + then
> + [ "$NO_RESET_OSNOISE" == 1 ] || reset_osnoise
> + shift
> + while shift
> + do
> + [ "$1" == "" ] && continue
> + option=$(echo $1 | cut -d '=' -f 1)
> + value=$(echo $1 | cut -d '=' -f 2)
> + echo "option: $option, value: $value"
> + echo "$value" > "/sys/kernel/tracing/osnoise/$option"
> || return 1
> + done
> + fi
> +
> + NO_RESET_OSNOISE=1 check "$arg1" "$arg2"
> +}
> +
> set_timeout() {
> TIMEOUT="timeout -v -k 15s $1"
> }
> diff --git a/tools/tracing/rtla/tests/osnoise.t
> b/tools/tracing/rtla/tests/osnoise.t
> index 86596e547893..e5995c03c790 100644
> --- a/tools/tracing/rtla/tests/osnoise.t
> +++ b/tools/tracing/rtla/tests/osnoise.t
> @@ -16,4 +16,10 @@ check "verify the --trace param" \
> check "verify the --entries/-E param" \
> "osnoise hist -P F:1 -c 0 -r 900000 -d 1M -b 10 -E 25"
>
> +# Test setting default period by putting an absurdly high period
> +# and stopping on threshold.
> +# If default period is not set, this will time out.
> +check_with_osnoise_options "apply default period" \
> + "osnoise hist -s 1" period_us=600000000
> +
> test_end
> --
> 2.48.1
>
>
>
looks correct
change "stop" to "stopping" in description
Reviewed-by: John Kacur <[email protected]>
