On Fri, 14 Mar 2025 16:50:49 +0100 Arnd Bergmann <[email protected]> wrote:
> From: Arnd Bergmann <[email protected]> > > The tracing code fails to build when CONFIG_MODULES is disabled: > > kernel/trace/trace.c: In function 'save_mod': > kernel/trace/trace.c:6041:45: error: invalid use of undefined type 'struct > module' > 6041 | entry->mod_addr = (unsigned long)mod->mem[MOD_TEXT].base; > | ^~ > > The problem here is that 'struct module' is not defined in this configuration. > > Enclose the functions in another #ifdef, just like other parts of this file > already are. > > Fixes: dca91c1c5468 ("tracing: Have persistent trace instances save module > addresses") > Signed-off-by: Arnd Bergmann <[email protected]> > --- Thanks, but Masami already sent one fix where I commented on and he then sent an update: https://lore.kernel.org/all/174188321162.3845006.12665585959241736399.st...@mhiramat.tok.corp.google.com/ and the update: https://lore.kernel.org/all/174230515367.2909896.8132122175220657625.st...@mhiramat.tok.corp.google.com/ -- Steve
