On Fri, 18 Jul 2025 23:37:40 -0500 Jeremy Linton <[email protected]> wrote:
> uprobe_warn() is passed a task structure, yet its using current. For > the most part this shouldn't matter, but since a task structure is > provided, lets use it. > > Signed-off-by: Jeremy Linton <[email protected]> Looks good to me. BTW, is it a bug? This is introduced by commit 248d3a7b2f10 ("uprobes: Change uprobe_copy_process() to dup return_instances"), but there is no excuse why it uses current instead of @t. Acked-by: Masami Hiramatsu (Google) <[email protected]> Thanks, > --- > kernel/events/uprobes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 4c965ba77f9f..2dc4fed837a2 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -121,7 +121,7 @@ struct xol_area { > > static void uprobe_warn(struct task_struct *t, const char *msg) > { > - pr_warn("uprobe: %s:%d failed to %s\n", current->comm, current->pid, > msg); > + pr_warn("uprobe: %s:%d failed to %s\n", t->comm, t->pid, msg); > } > > /* > -- > 2.50.1 > -- Masami Hiramatsu (Google) <[email protected]>
