On Wed, Aug 20, 2025 at 02:19:15PM +0200, Jiri Olsa wrote:

> > This seems needlessly restrictive. Something like:
> > 
> > is_nop5(const char *buf)
> > {
> >     struct insn insn;
> > 
> >     ret = insn_decode_kernel(&insn, buf)
> >     if (ret < 0)
> >             return false;
> > 
> >     if (insn.length != 5)
> >             return false;
> > 
> >     if (insn.opcode[0] != 0x0f ||
> >         insn.opcode[1] != 0x1f)
> >             return false;
> > 
> >     return true;
> > }
> > 
> > Should do I suppose.
> 
> ok, looks good, should I respin with this, or is follow up ok?

I cleaned up already; I pushed out these patches to queue/perf/core and
added a few of my own.

I will need to write better Changelogs, and post them, but I need to run
some errants first.

Reply via email to