On Tue, 9 Sep 2025 17:10:16 +0100 Vincent Donnefort <[email protected]> wrote:
> > I'm more worried about the allocation not being big enough for the rb_desc > > being filled. I just noticed that the trace_remote_register() function is > > missing a kerneldoc header. Please add one and specify what the parameters > > are for as well as their requirements. > > > > It's fine to state that the allocation of desc must match what the cpumask > > is. But the lack of comments about what the function does and what is > > expected of the parameters makes it hard to know if it is performing > > properly. > > Ok, will do! > > I could also add a desc_size parameter to make sure we won't overflow the > given > desc? I wonder if we should just to make sure things are checked. Having a bitmask determine the size is kinda strange. -- Steve
