Every trace event can take up to 5K of memory in text and metadata regardless if they are used or not. Trace events should not be created if they are not used. Currently there's several events in the kernel that are defined but unused, either because their callers were removed without removing the trace event with it, or a config hides the trace event caller but not the trace event itself. And in some cases, trace events were simply added but were never called for whatever reason. The number of unused trace events continues to grow.
This patch series aims to fix this. The first patch moves the elf parsing out of sorttable.c so that it can be used by other tooling. The second patch creates a new program to run during build called tracepoint-update (note this may be extended to do other tracepoint modifications in the future). It also creates a new section called __tracepoint_check, where all callers of a tracepoint creates a variable that is placed in this section with the name of the tracepoint they use. The scripts/tracepoint-update.c is used to find tracepoints that are defined but not used which would mean they would not be in the __tracepoint_check section. It sorts the names from that section, and then reads the __tracepoint_strings section that has all compiled in tracepoint names. It makes sure that every tracepoint is found in the check section and if not, it prints a warning message about it. This lists the missing tracepoints at build time. The third patch adds EXPORT_TRACEPOINT() to the __tracepoint_check section as well. There was several locations that adds tracepoints in the kernel proper that are only used in modules. It was getting quite complex trying to move things around that I just decided to make any tracepoint in a EXPORT_TRACEPOINT "used". I'm using the analogy of static and global functions. An unused static function gets a warning but an unused global one does not. The last patch triggers warnings when a module defines a tracepoint but does not use it. Instead of hiding this behind a config option, where allmodconfig can cause the warnings to trigger, and we don't want current warnings to suddenly appear. Have the warnings trigger by a new make command line: make UT=1 This will enable the unused tracepoints warnings. Now this should not be an issue to upstream before all warnings are removed. When all current warnings are removed, we can then make this the default option where it will always cause the build to warn if there's a unused tracepoint defined. Changes since v8: https://lore.kernel.org/linux-trace-kernel/[email protected]/ - Instead of hiding the unused tracepoint warnings behind a config option, which means allmodconfig will trigger it, make it a make command line option. Now to enable the warnings, on must run make UT=1 - Trigger warnings for modules as well as built in unused tracepoints. Steven Rostedt (4): sorttable: Move ELF parsing into scripts/elf-parse.[ch] tracing: Add a tracepoint verification check at build time tracepoint: Do not warn for unused event that is exported tracing: Add warnings for unused tracepoints for modules ---- Makefile | 15 ++ include/asm-generic/vmlinux.lds.h | 1 + include/linux/tracepoint.h | 13 ++ scripts/Makefile | 6 + scripts/Makefile.modfinal | 7 + scripts/elf-parse.c | 198 ++++++++++++++++ scripts/elf-parse.h | 305 ++++++++++++++++++++++++ scripts/link-vmlinux.sh | 7 + scripts/sorttable.c | 477 +++----------------------------------- scripts/tracepoint-update.c | 239 +++++++++++++++++++ 10 files changed, 825 insertions(+), 443 deletions(-) create mode 100644 scripts/elf-parse.c create mode 100644 scripts/elf-parse.h create mode 100644 scripts/tracepoint-update.c
