On Mon, Oct 27, 2025 at 11:38:50PM +0100, Jiri Olsa wrote: > On Mon, Oct 27, 2025 at 01:19:52PM -0700, Josh Poimboeuf wrote: > > On Mon, Oct 27, 2025 at 01:52:18PM +0000, [email protected] wrote: > > > Does this revert re-introduce the BPF selftest failure that was fixed in > > > 2019? The test > > > tools/testing/selftests/bpf/prog_tests/stacktrace_map_raw_tp.c > > > still exists in the kernel tree. > > > > I have the same question. And note there may be subtle differences > > between the frame pointer and ORC unwinders. The testcase would need to > > pass for both. > > as I wrote in the other email that test does not check ips directly, > it just compare stacks taken from bpf_get_stackid and bpf_get_stack > helpers.. so it passes for both orc and frame pointer unwinder
Ok. So the original fix wasn't actually a fix at all? It would be good to understand that and mention it in the commit log. Otherwise it's not clear why it's ok to revert a fix with no real explanation. -- Josh
