On Mon, Oct 27, 2025 at 04:33:59PM +0100, Tomas Glozar wrote:
> Add -v flag to prove command to also print the names of tests that
> succeeded, not only those that failed, to allow easier debugging of the
> test suite.
> 
> Also, drop printing the option and value to stdout in
> check_with_osnoise_options, which was a debugging print that was
> accidentally left in the final commit, and which would be otherwise now
> visible in make check output, as stdout is no longer suppressed.
> 
> Suggested-by: Crystal Wood <[email protected]>
> Signed-off-by: Tomas Glozar <[email protected]>
> ---
>  tools/tracing/rtla/Makefile        | 2 +-
>  tools/tracing/rtla/tests/engine.sh | 1 -
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/tracing/rtla/Makefile b/tools/tracing/rtla/Makefile
> index aef814b639b7..2701256abaf3 100644
> --- a/tools/tracing/rtla/Makefile
> +++ b/tools/tracing/rtla/Makefile
> @@ -110,6 +110,6 @@ clean: doc_clean fixdep-clean
>       $(Q)rm -rf feature
>       $(Q)rm -f src/timerlat.bpf.o src/timerlat.skel.h 
> example/timerlat_bpf_action.o
>  check: $(RTLA) tests/bpf/bpf_action_map.o
> -     RTLA=$(RTLA) BPFTOOL=$(SYSTEM_BPFTOOL) prove -o -f tests/
> +     RTLA=$(RTLA) BPFTOOL=$(SYSTEM_BPFTOOL) prove -o -f -v tests/
>  examples: example/timerlat_bpf_action.o
>  .PHONY: FORCE clean check
> diff --git a/tools/tracing/rtla/tests/engine.sh 
> b/tools/tracing/rtla/tests/engine.sh
> index c7de3d6ed6a8..ed261e07c6d9 100644
> --- a/tools/tracing/rtla/tests/engine.sh
> +++ b/tools/tracing/rtla/tests/engine.sh
> @@ -105,7 +105,6 @@ check_with_osnoise_options() {
>                       [ "$1" == "" ] && continue
>                       option=$(echo $1 | cut -d '=' -f 1)
>                       value=$(echo $1 | cut -d '=' -f 2)
> -                     echo "option: $option, value: $value"
>                       echo "$value" > "/sys/kernel/tracing/osnoise/$option" 
> || return 1
>               done
>       fi
> -- 
> 2.51.0
> 

Reviewed-by: Wander Lairson Costa <[email protected]>


Reply via email to