Re: [PATCH v2] function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously

[Steven Rostedt]

On Tue, 11 Nov 2025 21:54:32 +0800
Donglin Peng <dolinux.p...@gmail.com> wrote:

> +     /* Store the retaddr in args[0] */
> +     if (type == TRACE_GRAPH_RETADDR_ENT)
> +             entry->args[i++] = retaddr;
> +
>  #ifdef CONFIG_HAVE_FUNCTION_ARG_ACCESS_API
> -     if (fregs) {
> -             for (int i = 0; i < FTRACE_REGS_MAX_ARGS; i++)
> -                     entry->args[i] = ftrace_regs_get_argument(fregs, i);
> +     if (store_args) {
> +             while (i < nr_args) {

Nit, this could stay as a for loop. You just don't initialize the 'i':

                for (; i < nr_args; i++) {

> +                     entry->args[i] = ftrace_regs_get_argument(fregs,
> +                                             i - (type == 
> TRACE_GRAPH_RETADDR_ENT ? 1 : 0));
> +                     i++;

Then you don't need the "i++" here.

-- Steve

> +             }
>       }