On Fri, 2 Jan 2026 14:31:48 -0500 Steven Rostedt <[email protected]> wrote:
> From: Steven Rostedt <[email protected]> > > The code has integrity checks to make sure that depth never goes below > zero. But the depth field has recently been converted to unsigned long > from "int" (for alignment reasons). As unsigned long can never be less > than zero, the integrity checks no longer work. > > Convert depth to long from unsigned long to allow the integrity checks to > work again. > > Cc: [email protected] > Reported-by: Dan Carpenter <[email protected]> > Closes: https://lore.kernel.org/all/[email protected]/ > Fixes: f83ac7544fbf7 ("function_graph: Enable funcgraph-args and > funcgraph-retaddr to work simultaneously") > Signed-off-by: Steven Rostedt (Google) <[email protected]> Looks good to me. Acked-by: Masami Hiramatsu (Google) <[email protected]> Thanks, > --- > include/linux/ftrace.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > index 770f0dc993cc..a3a8989e3268 100644 > --- a/include/linux/ftrace.h > +++ b/include/linux/ftrace.h > @@ -1167,7 +1167,7 @@ static inline void ftrace_init(void) { } > */ > struct ftrace_graph_ent { > unsigned long func; /* Current function */ > - unsigned long depth; > + long depth; /* signed to check for less than zero */ > } __packed; > > /* > -- > 2.51.0 > -- Masami Hiramatsu (Google) <[email protected]>
