The actions_add_trace_output() and actions_add_shell() functions were
using calloc() followed by strcpy() to allocate and copy a string.
This can be simplified by using strdup(), which allocates memory and
copies the string in a single step.

Replace the calloc() and strcpy() calls with strdup(), making the
code more concise and readable.

Signed-off-by: Wander Lairson Costa <[email protected]>
---
 tools/tracing/rtla/src/actions.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/tracing/rtla/src/actions.c b/tools/tracing/rtla/src/actions.c
index ff7811e175930..090d514fe4126 100644
--- a/tools/tracing/rtla/src/actions.c
+++ b/tools/tracing/rtla/src/actions.c
@@ -69,8 +69,7 @@ actions_add_trace_output(struct actions *self, const char 
*trace_output)
 
        self->present[ACTION_TRACE_OUTPUT] = true;
        action->type = ACTION_TRACE_OUTPUT;
-       action->trace_output = calloc_fatal(strlen(trace_output) + 1, 
sizeof(char));
-       strcpy(action->trace_output, trace_output);
+       action->trace_output = strdup_fatal(trace_output);
 }
 
 /*
@@ -97,8 +96,7 @@ actions_add_shell(struct actions *self, const char *command)
 
        self->present[ACTION_SHELL] = true;
        action->type = ACTION_SHELL;
-       action->command = calloc_fatal(strlen(command) + 1, sizeof(char));
-       strcpy(action->command, command);
+       action->command = strdup_fatal(command);
 }
 
 /*
-- 
2.52.0


Reply via email to