On 2026-01-06 13:30, Paul E. McKenney wrote:
On Tue, Jan 06, 2026 at 10:08:44AM -0500, Mathieu Desnoyers wrote:
[...]
Re-reading the comment and your explanation, I think the comments are
clear enough. One nit I found while reading though:
include/linux/srcutree.h:
* Note that both this_cpu_inc() and atomic_long_inc() are RCU read-side
* critical sections either because they disables interrupts, because
disables -> disable
Like this?
Looks good !
Reviewed-by: Mathieu Desnoyers <[email protected]>
Thanks,
Mathieu
Thanx, Paul
------------------------------------------------------------------------
commit b3fc7ac622a19fcf921871be097e3536847406cd
Author: Paul E. McKenney <[email protected]>
Date: Tue Jan 6 10:28:10 2026 -0800
srcu: Fix s/they disables/they disable/ typo in srcu_read_unlock_fast()
Typo fix in srcu_read_unlock_fast() header comment.
Reported-by: Mathieu Desnoyers <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
diff --git a/include/linux/srcutree.h b/include/linux/srcutree.h
index d6f978b50472d..727719a3cbeb9 100644
--- a/include/linux/srcutree.h
+++ b/include/linux/srcutree.h
@@ -259,7 +259,7 @@ static inline struct srcu_ctr __percpu
*__srcu_ctr_to_ptr(struct srcu_struct *ss
* srcu_read_unlock_fast().
*
* Note that both this_cpu_inc() and atomic_long_inc() are RCU read-side
- * critical sections either because they disables interrupts, because
+ * critical sections either because they disable interrupts, because
* they are a single instruction, or because they are read-modify-write
* atomic operations, depending on the whims of the architecture.
* This matters because the SRCU-fast grace-period mechanism uses either
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
