On Wed, Jan 7, 2026 at 10:47 AM Tomas Glozar <[email protected]> wrote: > > st 7. 1. 2026 v 13:43 odesílatel Wander Lairson Costa > <[email protected]> napsal: > > > > > > The deduplication idea is good, but I find the name of the helper > > > quite confusing. The main function of the helper is not to restart > > > tracing, it is to handle a latency threshold overflow - restarting > > > tracing is only one of possible effects, and one that is only applied > > > when using --on-threshold continue which is not the most common use > > > case. Could something like common_handle_stop_tracing() perhaps be > > > better? > > > > > > > Sure, I will change the name in v3. > > > > Thanks. > > > > > +enum restart_result { > > > > + RESTART_OK, > > > > + RESTART_STOP, > > > > + RESTART_ERROR = -1, > > > > +}; > > > > > > Do we really need a separate return value enum just for this one helper? > > > > > > > If it was success/failure type of return value, we wouldn't need. > > However, a three state code, I think it is worth for code readiness. > > Do you have something else in mind? > > > > The main loop can simply use the continue flag, just like in the old > version, no need to duplicate that information into the return value > of common_restart(). >
Ok, I will change it in v3. > Tomas >
