On Wed, 7 Jan 2026 16:15:10 -0500 Steven Rostedt <[email protected]> wrote:
> From: Steven Rostedt <[email protected]> > > In the very unlikely event that tracing_update_buffers() fails in > trace_printk_init_buffers(), report the failure so that it is known. > > Link: > https://lore.kernel.org/all/[email protected]/ Good catch! Looks good to me. Acked-by: Masami Hiramatsu (Google) <[email protected]> Thanks, > > Suggested-by: Li Zhong <[email protected]> > Signed-off-by: Steven Rostedt (Google) <[email protected]> > --- > kernel/trace/trace.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index 2d387d56dcd4..1722e01e2238 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -3418,9 +3418,10 @@ void trace_printk_init_buffers(void) > pr_warn("**********************************************************\n"); > > /* Expand the buffers to set size */ > - tracing_update_buffers(&global_trace); > - > - buffers_allocated = 1; > + if (tracing_update_buffers(&global_trace) < 0) > + pr_err("Failed to expand tracing buffers for trace_printk() > calls\n"); > + else > + buffers_allocated = 1; > > /* > * trace_printk_init_buffers() can be called by modules. > -- > 2.51.0 > > -- Masami Hiramatsu (Google) <[email protected]>
