On Wed, Apr 01, 2026 at 11:02:55PM +0900, Masami Hiramatsu (Google) wrote:
> From: Masami Hiramatsu (Google) <[email protected]>
> 
> If user configures `kernel.key` in bootconfig, the 'key' is shown
> in kernel cmdline (/proc/cmdline) and kernel boot parameter
> handler associated with 'key' is invoked. However, since the
> bootconfig does not support the parameter defined with early_param,
> those keys are shown in '/proc/cmdline' but not handled by kernel.
> 
> This could easily mislead users who expected to be able to specify
> early parameters via the boot configuration, leading them to wonder
> why it doesn't work.
> 
> Let's skip printing out early params to cmdline buffer, and warn
> if there is such parameters in bootconfig.
> 
> Signed-off-by: Masami Hiramatsu (Google) <[email protected]>

Reviewed-by: Breno Leitao <[email protected]>

> +static bool __init is_early_param(const char *param)
> +{
> +     const struct obs_kernel_param *p;
> +
> +     for (p = __setup_start; p < __setup_end; p++) {
> +             if (p->early && parameq(param, p->str))
> +                     return true;
> +     }

nit: I don't think you need the parenthesis ({) for the ifs in here.

Reply via email to