On Tue 07-04-26 09:21:14, Jeff Layton wrote: > If a NFS client requests a directory delegation with a notification > bitmask covering directory change events, the server shouldn't recall > the delegation. Instead the client will be notified of the change after > the fact. > > Add support for ignoring lease breaks on directory changes. Add a new > flags parameter to try_break_deleg() and teach __break_lease how to > ignore certain types of delegation break events. > > Signed-off-by: Jeff Layton <[email protected]>
Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> > @@ -222,6 +225,10 @@ struct file_lease *locks_alloc_lease(void); > #define LEASE_BREAK_LAYOUT BIT(2) // break layouts only > #define LEASE_BREAK_NONBLOCK BIT(3) // non-blocking break > #define LEASE_BREAK_OPEN_RDONLY BIT(4) // readonly open event > +#define LEASE_BREAK_DIR_CREATE BIT(6) // dir deleg create > event > +#define LEASE_BREAK_DIR_DELETE BIT(7) // dir deleg delete > event > +#define LEASE_BREAK_DIR_RENAME BIT(8) // dir deleg rename > event Just curious why you've left out bit 5 here... :) Honza -- Jan Kara <[email protected]> SUSE Labs, CR
