From: Markus Elfring <[email protected]> Date: Tue, 16 Jun 2026 22:22:52 +0200
Use an additional label so that a bit of exception handling can be better reused at the end of this function implementation. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- kernel/trace/trace_events_trigger.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/kernel/trace/trace_events_trigger.c b/kernel/trace/trace_events_trigger.c index 655db2e82513..7e17dd6d5b50 100644 --- a/kernel/trace/trace_events_trigger.c +++ b/kernel/trace/trace_events_trigger.c @@ -1789,17 +1789,14 @@ int event_enable_trigger_parse(struct event_command *cmd_ops, enable_data->file = event_enable_file; trigger_data = trigger_data_alloc(cmd_ops, cmd, param, enable_data); - if (!trigger_data) { - kfree(enable_data); - return ret; - } + if (!trigger_data) + goto out_free_enable_data; if (remove) { event_trigger_unregister(cmd_ops, file, glob+1, trigger_data); kfree(trigger_data); - kfree(enable_data); ret = 0; - return ret; + goto out_free_enable_data; } /* Up the trigger_data count to make sure nothing frees it on failure */ @@ -1837,6 +1834,7 @@ int event_enable_trigger_parse(struct event_command *cmd_ops, out_free: event_trigger_reset_filter(cmd_ops, trigger_data); event_trigger_free(trigger_data); +out_free_enable_data: kfree(enable_data); return ret; -- 2.54.0
